fix(dropdowns): compose onKeyDown handler for multiselect #1277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since #1176, some of Garden's dropdown behaviors have changed slightly. This pull request addresses a small difference in behavior for the
Multiselect
component which results in a bug for some consumers.Detail
When consumers pass in an
onKeyDown
handler, it overrides Garden's internalonKeyDown
code causing problems searching the multiselect. One example is that theSpace
key is not registered. Try searching for an item with a space in this example.Although, consumers should use
onInputChange
as shown on the API docs, theMultiselect
component should still register the key strokes as expected if they choose to add anonKeyDown
handler.This PR addresses the issue by composing the
onKeyDown
handlers if it is passed into the component.Checklist
yarn start
)?bedrock
)