Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loaders): changed Dots and Spinner roles from progressbar to img #1451

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

jgorfine-zendesk
Copy link
Contributor

Description

To make the Dots and Spinner components accessible to assistive tech users — and to make them conform to WCAG 2.1 Success Criterion 4.1.2 Name, Role, Value (level A) — this PR changes the SVG role from progressbar to img.

Detail

Spinner

Screenshot of Chrome DevTools showing Spinner element now has a role of img

Dots

Screenshot of Chrome DevTools showing Dots element now has a role of img

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@jzempel jzempel merged commit fa06c2f into main Nov 3, 2022
@jzempel jzempel deleted the jgorfine/remove-progressbar-role-from-loaders branch November 3, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants