Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo): prevent strict mode tool in production Storybook #1459

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Nov 14, 2022

Description

Conditionally remove the tool, since StrictMode does not impact production.

Detail

https://reactjs.org/docs/strict-mode.html

Checklist

  • πŸ‘Œ design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🀘 renders as expected with Bedrock CSS (?bedrock)
  • πŸ’‚β€β™‚οΈ includes new unit tests. Maintain existing coverage (always >= 96%)
  • β™Ώ tested for WCAG 2.1 AA accessibility compliance
  • πŸ“ tested in Chrome, Firefox, Safari, and Edge

@jzempel jzempel merged commit 1fb499e into main Nov 14, 2022
@jzempel jzempel deleted the jzempel/dev-strict branch November 14, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants