Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tables): add isSticky prop to Head component #1482

Merged
merged 4 commits into from
Dec 15, 2022
Merged

feat(tables): add isSticky prop to Head component #1482

merged 4 commits into from
Dec 15, 2022

Conversation

Francois-Esquire
Copy link
Contributor

@Francois-Esquire Francois-Esquire commented Dec 15, 2022 •
edited

Description

Adds isSticky prop to Head component for react-tables package.

Detail

Example usage preview:
Screen Shot 2022-12-15 at 11 21 44 AM

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@Francois-Esquire Francois-Esquire requested a review from a team as a code owner December 15, 2022 16:24
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 96.106% when pulling e713a10 on jzempel/sticky-table-header into 5157937 on main.

@Francois-Esquire Francois-Esquire merged commit 7616241 into main Dec 15, 2022
@Francois-Esquire Francois-Esquire deleted the jzempel/sticky-table-header branch December 15, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzempel jzempel jzempel approved these changes

Assignees
No one assigned
Labels
PR: New Feature 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Francois-Esquire @coveralls @jzempel @zendesk-garden