Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theming): improve getColor memoization resolver performance #1545

Merged
merged 1 commit into from
May 4, 2023

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented May 4, 2023

Description

This update only feed portions of the theme to the resolver that are actually used by the utility – palette and colors. This micro-optimizes the time spent to stringify theme.

@jzempel jzempel requested a review from a team as a code owner May 4, 2023 17:41
@coveralls
Copy link

Coverage Status

Coverage: 96.149% (+0.002%) from 96.146% when pulling 15614c6 on jzempel/color-resolver into 9afa534 on main.

@jzempel jzempel merged commit 33a7b1f into main May 4, 2023
2 checks passed
@jzempel jzempel deleted the jzempel/color-resolver branch May 4, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants