Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chrome): consistent focus style for sub nav items #1558

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

Francois-Esquire
Copy link
Contributor

@Francois-Esquire Francois-Esquire commented Jun 12, 2023

Description

Fixes the focus color for CollapsibleSubNavItem within the Chrome context; follows the same behavior of SubNavItem.

Checklist

  • πŸ‘Œ design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🀘 renders as expected with Bedrock CSS (?bedrock)
  • πŸ’‚β€β™‚οΈ includes new unit tests. Maintain existing coverage (always >= 96%)
  • β™Ώ tested for WCAG 2.1 AA accessibility compliance
  • πŸ“ tested in Chrome, Firefox, Safari, and Edge

@coveralls
Copy link

Coverage Status

coverage: 96.154%. remained the same when pulling c89cf63 on mike/fix/chrome-collapsible-subnav into d1774fd on main.

@Francois-Esquire Francois-Esquire merged commit 22d233b into main Jun 14, 2023
6 checks passed
@Francois-Esquire Francois-Esquire deleted the mike/fix/chrome-collapsible-subnav branch June 14, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants