Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avatars): explicitly set box sizing for status indicator icon container #1564

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

Francois-Esquire
Copy link
Contributor

@Francois-Esquire Francois-Esquire commented Jul 5, 2023

Description

Fixes a visual bug when box-sizing computes to a value other than content-box for the StatusIndicator icon container element.

Detail

This fix also includes another fix to the StatusIndicator storybook pattern. It wraps the Avatar in an IconButton component.

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

Copy link
Contributor

@geotrev geotrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there any value in adding a test case? I'm not sure how you would test it - just curious if anything sticks out to you there.

@Francois-Esquire
Copy link
Contributor Author

Francois-Esquire commented Jul 6, 2023

LGTM. Is there any value in adding a test case? I'm not sure how you would test it - just curious if anything sticks out to you there.

Good question! I don't think there is in this case. However with logic backed CSS, I would see the value in adding a test case.

@Francois-Esquire Francois-Esquire merged commit 9e5618b into main Jul 6, 2023
6 checks passed
@Francois-Esquire Francois-Esquire deleted the mike/fix/status-indicator-box-sizing branch July 6, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants