fix(combobox): address multiselectable state issues with new TagGroup
component
#1589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses some touchy expand/collapse state bugs for multiselectable tag groups. The
TagGroup
is an internal-only component that renders a list ofTag
components and{children}
(theStyledTagsButton
) as a final sibling.Detail
Also shimmed in:
aria-labelledby
label readout hack for screenreadersisEditable={false}
combobox valueChecklist
design updates will be Garden Designer approved (add the designer as a reviewer)yarn start
)?bedrock
)