Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): address multiselectable state issues with new TagGroup component #1589

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Aug 2, 2023

Description

Addresses some touchy expand/collapse state bugs for multiselectable tag groups. The TagGroup is an internal-only component that renders a list of Tag components and {children} (the StyledTagsButton) as a final sibling.

Detail

Also shimmed in:

  • an input aria-labelledby label readout hack for screenreaders
  • preventing double readout of isEditable={false} combobox value

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@jzempel jzempel requested a review from a team as a code owner August 2, 2023 14:21
@coveralls
Copy link

coveralls commented Aug 2, 2023

Coverage Status

coverage: 95.491% (+0.004%) from 95.487% when pulling f277056 on jzempel/fix-tag-group into bcafe87 on main.

Copy link
Contributor

@geotrev geotrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major here, just questions mainly. The interactions feel much better. Making the tags all visible on focus is a great workaround!

@jzempel jzempel merged commit 1c6a065 into main Aug 3, 2023
5 checks passed
@jzempel jzempel deleted the jzempel/fix-tag-group branch August 3, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants