feat(dropdowns)!: removes object type from Option value prop
#1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
reviewed
Apr 3, 2024
| @@ -16,8 +16,7 @@ import { IOptGroupProps, IOptionProps } from '../../types'; | |||
| * | |||
| * @returns A string based on `option.value`. | |||
| */ | |||
| export const toString = (option: IOption) => | |||
| typeof option.value === 'string' ? option.value : JSON.stringify(option.value); | |||
| export const toString = (option: IOption) => option.value; | |||
There was a problem hiding this comment.
Is this utility still used anywhere? It doesn't seem like much of a utility anymore 😉
There was a problem hiding this comment.
Won't you want to stroll down memory lane in six months? 😛
jzempel
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optionto no longer accept objects for thevalueprop.Checklist
👌 design updates will be Garden Designer approved (add the designer as a reviewer)npm start)⬅️ renders as expected with reversed (RTL) direction🤘 renders as expected with Bedrock CSS (?bedrock)💂♂️ includes new unit tests. Maintain existing coverage (always >= 96%)♿ tested for WCAG 2.1 AA accessibility compliance