-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chrome)!: removes Subnav component #1787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After you GH auth with CircleCI, we should be seeing an auto deployment on the PR π
@@ -90,14 +83,10 @@ import README from '../README.md'; | |||
isFluid: { control: 'boolean' }, | |||
skipNav: { name: 'children', table: { category: 'SkipNav' } }, | |||
isExpanded: { name: 'Nav isExpanded', table: { category: 'Story' } }, | |||
isWrapped: { name: 'Nav/SubNav isWrapped', table: { category: 'Story' } }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still want the isWrapped
control for Nav
.
hasHeader: boolean; | ||
headerItems: IHeaderItem[]; | ||
hasFooter: boolean; | ||
footerItems: IFooterItem[]; | ||
isExpanded: boolean; | ||
isWrapped: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
}} | ||
> | ||
<Nav.ItemIcon>{NAV_ICONS[index] || <NavIcon />}</Nav.ItemIcon> | ||
<Nav.ItemText isWrapped={isWrapped}>{item.text}</Nav.ItemText> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's definitely keep this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] should be isWrapped: { name: 'Nav isWrapped', table: { category: 'Story' } },
rather than 'Nav/Subnav isWrapped'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than JZ's comment, looks good in code & demo.
Description
Subnav
component and associated dependencies.Checklist
π design updates will be Garden Designer approved (add the designer as a reviewer)npm start
)β¬ οΈ renders as expected with reversed (RTL) directionπ€ renders as expected with Bedrock CSS (?bedrock
)πββοΈ includes new unit tests. Maintain existing coverage (always >= 96%)βΏ tested for WCAG 2.1 AA accessibility compliance