-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds StyledBaseIcon to various icon components #1792
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geotrev
force-pushed
the
george/styled-icon-refactor
branch
from
April 18, 2024 20:44
6a68c25
to
fc5ef83
Compare
geotrev
force-pushed
the
george/styled-icon-refactor
branch
from
April 18, 2024 21:24
ec53455
to
765f345
Compare
geotrev
commented
Apr 18, 2024
error: <ErrorIcon />, | ||
warning: <WarningIcon />, | ||
info: <InfoIcon /> | ||
}[type]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not critical to this PR but I can't say no to DRY opportunities.
geotrev
changed the title
🚧 feat: adds StyledBaseIcon to various icon components
feat: adds StyledBaseIcon to various icon components
Apr 19, 2024
jzempel
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this cleanup looks fantastic ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a follow up to #1791, updates various components with new
StyledBaseIcon
.Detail
Key changes to note:
React.cloneElement(...)
instances by extendingStyledBaseIcon
Package/component checklist
react-buttons
StyledIcon
react-forms
StyledFileIcon
StyledTextMediaFigure
react-dropdowns
StyledInputIcon
StyledOptionIcon
StyledOptionTypeIcon
react-typography
StyledIcon
react-notifications
StyledIcon
StyledGlobalAlertIcon
react-pagination
StyledIcon
react-tags
StyledAvatar
Testing considerations:
IconButton
instances (used my multiple packages)Button.StartIcon
andButton.EndIcon
instances (used by multiple packages)Checklist
👌 design updates will be Garden Designer approved (add the designer as a reviewer)npm start
)?bedrock
)