feat(theming): add new getCheckeredBackground utility
#1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
commented
Apr 19, 2024
| @@ -134,7 +134,7 @@ const toProperty = (object: object, path: string) => { | |||
| * `shade`, `offset`, and `transparency` are used as fallbacks to determine the | |||
| * color. | |||
| * | |||
| * @param {Object} [options.theme] Provides values used to resolve the desired color | |||
| * @param {Object} options.theme Provides values used to resolve the desired color | |||
There was a problem hiding this comment.
slipped in this JS doc required parameter cleanup
geotrev
approved these changes
Apr 22, 2024
|
Does this need a |
No. Should get captured in the CHANGELOG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
...and swap out redundant usage.
Detail
Note that final checkered colors will be established throughout the v9 design cycle. The
'border.default'variable was a best guess for now (and closest to the existing v8 color).Checklist
design updates will be Garden Designer approved (add the designer as a reviewer)npm start)?bedrock)tested for WCAG 2.1 AA accessibility compliance