Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: removes stale product colors from palette #1794

Merged
merged 2 commits into from Apr 23, 2024

Conversation

geotrev
Copy link
Contributor

@geotrev geotrev commented Apr 22, 2024

Description

Removes references to PALETTE.product.message and PALETTE.product.connect. Updates migration guide.

Detail

Checklist

  • πŸ‘Œ design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🀘 renders as expected with Bedrock CSS (?bedrock)
  • πŸ’‚β€β™‚οΈ includes new unit tests. Maintain existing coverage (always >= 96%)
  • β™Ώ tested for WCAG 2.1 AA accessibility compliance
  • πŸ“ tested in Chrome, Firefox, Safari, and Edge

@geotrev geotrev self-assigned this Apr 22, 2024
@geotrev geotrev requested a review from a team as a code owner April 22, 2024 20:04
@coveralls
Copy link

coveralls commented Apr 22, 2024

Coverage Status

coverage: 96.22% (-0.003%) from 96.223%
when pulling 002dcaa on george/product-palette-cleanup
into a745bde on next.

Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, plz note these removals in migration.md πŸ™

@geotrev geotrev changed the title 🚧 feat!: removes stale product colors from palette feat!: removes stale product colors from palette Apr 23, 2024
@geotrev geotrev requested a review from jzempel April 23, 2024 14:51
@geotrev geotrev merged commit 55eefa6 into next Apr 23, 2024
5 checks passed
@geotrev geotrev deleted the george/product-palette-cleanup branch April 23, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants