fix(theming): update palette color values #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ze-flo
reviewed
Apr 22, 2024
| <Canvas> | ||
| <Story | ||
| name="PALETTE" | ||
| args={{ palette: PALETTE }} |
There was a problem hiding this comment.
Should we let the user interact with the arguments for this story? If so, the current implementation will only track changes to the outer color keys. That's because Hue gets the colors from the theme.palette and not the palette object injected as an argument.
There was a problem hiding this comment.
I'm not super concerned about whether or not the story is interactive – more interested in demonstrating where the values are coming from. However, there is some copy/paste jank in here from the website implementation. Now cleaned up. 🧹
| <Grid.Col sm> | ||
| <Hue hue={hue1} /> | ||
| </Grid.Col> | ||
| {hue1 !== 'product' && <StyledCol sm>{hue2 && <Hue hue={hue2} />}</StyledCol>} |
There was a problem hiding this comment.
That's always true since product is excluded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated v9 palette color values and added an associated story demo.
Checklist
npm start)renders as expected with reversed (RTL) directionrenders as expected with Bedrock CSS (?bedrock)tested in Chrome, Firefox, Safari, and Edge