-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theming): add system opacity
values to the theme
#1797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about fallback values when theme.opacity
may contain invalid entries, but it may be too heavy handed to force consumers down an unexpected path vs letting getColor
provide users with an error.
@@ -25,6 +25,7 @@ | |||
- [ ] :ok_hand: design updates will be Garden Designer approved (add the designer as a reviewer) | |||
- [ ] :globe_with_meridians: demo is up-to-date (`npm start`) | |||
- [ ] :arrow_left: renders as expected with reversed (RTL) direction | |||
- [ ] :black_circle: renders as expected in dark mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
Ah, that reminds me, I wanted to handle invalid |
Description
This PR introduces a consistent set of themed opacity values and updates
getColor
to receive either one of the theme's100
-1200
keys or a value between0
and1
. Garden will strive to usetheme.opacity
keys for all v9 opacity/transparency applications.Detail
I weighed adding
opacity
under thecolors
theme structure, but stuck with root placement since CSS opacity applies to more than just color.Checklist
npm start
)renders as expected with reversed (RTL) directionrenders as expected with Bedrock CSS (?bedrock
)tested for WCAG 2.1 AA accessibility compliancetested in Chrome, Firefox, Safari, and Edge