Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(breadcrumbs): add support for aria-current #252

Merged
merged 4 commits into from
Jan 14, 2019
Merged

feat(breadcrumbs): add support for aria-current #252

merged 4 commits into from
Jan 14, 2019

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Jan 12, 2019

  • BREAKING CHANGE?

Description

Add container support for consumers that utilize anchor tags for final breadcrumb in the list.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 💂‍♂️ includes new unit and snapshot tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@coveralls
Copy link

coveralls commented Jan 12, 2019 •
edited

Coverage Status

Coverage increased (+0.008%) to 94.161% when pulling 35368da on jzempel/breadcrumb-current into 0a781f5 on master.

@jzempel jzempel merged commit c5984a6 into master Jan 14, 2019
@jzempel jzempel deleted the jzempel/breadcrumb-current branch January 14, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanseddon ryanseddon ryanseddon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jzempel @coveralls @ryanseddon