Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): replace encoded background images with inline SVGs #691

Merged
merged 14 commits into from
Apr 3, 2020

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Apr 1, 2020

Description

These changes address two important concerns:

  1. Mitigate radio, checkbox, and toggle mark visibility problems in Windows hi-contrast mode
  2. Eradicate all remaining usage of inline data URLs as background images in react-components – alleviating the potential need for img-src 'self' data: CSP (Content Security Policy) flags in order to use Garden components

Detail

Radios, checkboxes, and toggles should look/work exactly the same as https://garden.zendesk.com/react-components/forms/#basic. The only difference is that now they are implemented using inline SVGs instead of encoded SVG background images.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@jzempel jzempel marked this pull request as ready for review April 2, 2020 18:22
@jzempel jzempel requested a review from a team as a code owner April 2, 2020 18:22
@jzempel jzempel merged commit b0f5896 into master Apr 3, 2020
@jzempel jzempel deleted the jzempel/x-background-image branch April 3, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants