feat(typography): add Paragraph component #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+25
to
+27
| & + & { | ||
| margin-top: ${props => props.theme.lineHeights[props.size!]}; | ||
| } |
There was a problem hiding this comment.
This selector feels like application-specific logic to me. We don't affect margin in other components, shouldn't that be up to the consuming application?
There was a problem hiding this comment.
@Austin94 stylistically, this is the primary purpose of this component – to establish spacing between sibling paragraphs.
hzhu
approved these changes
Apr 21, 2020
austingreendev
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
<Paragraph>component to the@zendeskgarden/react-typographypackage. This covers opinionated Garden usage for the HTML<p>element.Detail
Demo pre-published for review: https://suspicious-noether-1ad97b.netlify.app/typography/#paragraph
Checklist
designer as a reviewer)
yarn start)analyzed via axe and evaluated using VoiceOver