-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(forms): allow multi-thumb range to allow track mouse interaction #727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Austin94 lookin' good. Please publish a demo and add selected designers as Reviewers. 🙏
@ginnywood @jzempel pre-published at https://austin-next.netlify.app/forms/#!/Basic/5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clicking in the spacing area (whenever the cursor changes to "pointer") of <Range>
affects the thumb. However, the same is only effective on MultiThumbRange
when the mouse is over the track.
@jzempel good catch. I've moved the |
Awesome! 🙌Great improvement, thanks for doing this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
673c91b
to
61b90e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice.
Description
This PR adds the ability to interact with the MultiThumbRange through clicking the range track. It determines the closest thumb from the selection and updates the value along with focusing the thumb for additional keyboard interaction.
This also supports the
step
property by rounding new values.Checklist
designer as a reviewer)
yarn start
)