Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menus): prevent inherited line-height from affecting positioning #776

Merged
merged 1 commit into from
Jun 12, 2020
Merged

fix(menus): prevent inherited line-height from affecting positioning #776

merged 1 commit into from
Jun 12, 2020

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Jun 11, 2020

Description

When combined with css-bedrock, we see top menu (with arrow) positioning that looks like this:

Screen Shot 2020-06-11 at 2 34 47 PM

Proper menu positioning is restored with this fix.

Detail

Currently affecting zendeskgarden/website#55

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@jzempel jzempel requested a review from a team as a code owner June 11, 2020 23:02
@jzempel jzempel requested a review from allisonacs June 11, 2020 23:02
@zendesk-garden zendesk-garden temporarily deployed to staging June 11, 2020 23:45 Inactive
@hzhu hzhu mentioned this pull request Jun 12, 2020
Merged
5 tasks
@jzempel jzempel merged commit 97c029a into master Jun 12, 2020
@jzempel jzempel deleted the jzempel/x-line-height branch June 12, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzhu hzhu hzhu approved these changes

@allisonacs allisonacs Awaiting requested review from allisonacs

Assignees
No one assigned
Labels
PR: Bug Fix 🐛
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jzempel @hzhu @zendesk-garden