Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dropdowns): allow Select to search with keyboard interaction #787

Merged
merged 1 commit into from
Jun 29, 2020
Merged

feat(dropdowns): allow Select to search with keyboard interaction #787

merged 1 commit into from
Jun 29, 2020

Conversation

austingreendev
Copy link
Contributor

@austingreendev austingreendev commented Jun 29, 2020 •
edited

Description

This is a cherry-pick of #786 for the v8 major

Detail

Similar to #786 JSDOM limitations make this addition difficult to test accurately.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@austingreendev austingreendev requested review from louisscruz and a team June 29, 2020 21:28
@zendesk-garden zendesk-garden temporarily deployed to staging June 29, 2020 22:05 Inactive
@austingreendev austingreendev merged commit 04ebfb9 into master Jun 29, 2020
@austingreendev austingreendev deleted the agreen/select-search branch June 29, 2020 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzempel jzempel jzempel approved these changes

@louisscruz louisscruz Awaiting requested review from louisscruz

Assignees
No one assigned
Labels
PR: New Feature 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@austingreendev @jzempel @zendesk-garden