Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forms): override Bedrock CSS [hidden] styling for radios, checkboxes, and toggles #789

Merged
merged 2 commits into from
Jul 1, 2020
Merged

fix(forms): override Bedrock CSS [hidden] styling for radios, checkboxes, and toggles #789

merged 2 commits into from
Jul 1, 2020

Conversation

jzempel
Copy link
Member

@jzempel jzempel commented Jul 1, 2020

Description

Fix for specificity ordering affecting hidden label examples on website.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@jzempel jzempel requested a review from a team as a code owner July 1, 2020 15:39
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.585% when pulling aa1de8d on jzempel/hidden-label into 8bf1276 on master.

@zendesk-garden zendesk-garden temporarily deployed to staging July 1, 2020 16:22 Inactive
@jzempel jzempel merged commit 63631b1 into master Jul 1, 2020
@jzempel jzempel deleted the jzempel/hidden-label branch July 1, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austingreendev austingreendev austingreendev approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jzempel @coveralls @austingreendev @zendesk-garden