chore(docs): migrate react-chrome to storybook #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austingreendev
commented
Sep 17, 2020
| const backgroundColor = getColor(hue, 600, theme); | ||
| const LIGHT_COLOR = 'white'; | ||
| const Chrome = React.forwardRef<HTMLDivElement, IChromeProps>(({ hue, isFluid, ...props }, ref) => { | ||
| const theme = useContext(ThemeContext); |
There was a problem hiding this comment.
The withTheme usage confuses the Storybook story-source plugin. This aligns the Theme usage with newer components.
There was a problem hiding this comment.
@Austin94 does this mean we'll be subsequently dropping withTheme throughout?
There was a problem hiding this comment.
I think it would be a good idea. Cleans up our prop-sheets throughout and also aligns us with eventual changes in styled-components v6+
| @@ -6,13 +6,14 @@ | |||
| */ | |||
|
|
|||
| import React, { HTMLAttributes } from 'react'; | |||
| import { StyledHeaderItemWrapper } from '../../styled'; | |||
| import { StyledHeaderItemWrapper, IStyledBaseHeaderItemProps } from '../../styled'; | |||
There was a problem hiding this comment.
Moving to TS for the examples found we were missing some types for this component.
jzempel
requested changes
Sep 18, 2020
|
@jzempel I've updated the root link for |
jzempel
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates our
react-chromedocumentation to storybook. It is a 1-to-1 migration so no changes in docs/examples should be noticeable.Checklist
👌 design updates are Garden Designer approved (add thedesigner as a reviewer)
yarn start)?bedrock)💂♂️ includes new unit tests