fix(modals): provide ref object for focusvisible #887
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was recently discovered that focusvisible behavior broke within modal components.
Detail
It looks like the
environment
changes when the modal is mounted but the change is not captured by theuseFocusVisible
hook.In order to capture this change, the
environment
is passed touseFocusVisible
as therelativeDocument
. AuseEffect
withinuseFocusVisible
re-runs the effect accordingly when therelativeDocument
is updated.🙏 Thanks @Austin94 for helping figure out the root problem.
Screenshots
Before:
After:
Checklist
yarn start
)?bedrock
)