Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(table): revise cell type definition #888

Merged
merged 2 commits into from
Sep 23, 2020
Merged

fix(table): revise cell type definition #888

merged 2 commits into from
Sep 23, 2020

Conversation

rossmoody
Copy link
Contributor

@rossmoody rossmoody commented Sep 22, 2020 •
edited by austingreendev

Description

This PR is a little bit of a reach as my TS knowledge is non-existent but I took a stab at a fix. While doing the Table examples for the site, I was getting an error that colSpan didn't exist on the Cell component. It looks like colSpan doesn't exist on HTMLAttributes but it does on ThHTMLAttributes.

Detail

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@rossmoody rossmoody requested a review from a team as a code owner September 22, 2020 21:28
@coveralls
Copy link

coveralls commented Sep 22, 2020 •
edited

Coverage Status

Coverage remained the same at 95.833% when pulling 4529948 on rmoody/type-table into d5ddd6f on main.

@zendesk-garden zendesk-garden temporarily deployed to staging September 22, 2020 22:05 Inactive
@zendesk-garden zendesk-garden temporarily deployed to staging September 22, 2020 23:03 Inactive
@austingreendev austingreendev merged commit 0223a77 into main Sep 23, 2020
@austingreendev austingreendev deleted the rmoody/type-table branch September 23, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austingreendev austingreendev austingreendev approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix 🐛
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rossmoody @coveralls @austingreendev @zendesk-garden