New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(menu): Don't render Menu when it's closed #89
Conversation
Pull Request Test Coverage Report for Build 330
π - Coveralls |
|
||
if (newSelectedKey === undefined) { | ||
newSelectedKey = selectedKey; | ||
{isOpen && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is the only change? π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep the rest was prettier reformatting, best viewed with ?w=1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π― thanks, Ryan~
if (!isOpen) { | ||
return false; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was deleted too @zillding
@jzempel coveralls has got confused due to the prettier format its complaining about new stuff that isn't actually new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Ryan! We can merge around the coveralls check.
Description
If you tried to make dynamic prop changes to
Menu
it would throw due to Popper.js trying to get the computed styles ofnull
.Detail
Simple fix here is to just not render the Menu when the menu is closed.
Checklist
designer as a reviewer)
component
yarn start
)src/index.js
export