chore(docs): migrate react-notifications examples to storybook #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzhu
changed the title
jzempel
requested changes
Oct 26, 2020
| control: 'boolean' | ||
| }, | ||
| type: { | ||
| control: { type: 'select', options: ['success', 'warning', 'error', 'info'] } |
There was a problem hiding this comment.
Please add support for the default undefined case.
Comment on lines
23
to
29
| <Title>Nori Grape Beet</Title> | ||
| <Paragraph> | ||
| Nori grape silver beet broccoli kombu beet greens fava bean potato quandong celery. | ||
| Bunya nuts black-eyed pea prairie turnip leek lentil turnip greens parsnip. Sea lettuce | ||
| lettuce water chestnut eggplant winter purslane fennel azuki bean earthnut pea sierra | ||
| leone bologi leek soko chicory celtuce parsley jícama salsify black-eyed pea quandong. | ||
| </Paragraph> |
There was a problem hiding this comment.
Can we see controls for the regular weight title and multi-line paragraph here?
There was a problem hiding this comment.
Yeah a control could be added for that.
Comment on lines
24
to
25
| Turnip greens yarrow ricebean rutabaga endive cauliflower sea lettuce kohlrabi amaranth | ||
| water |
There was a problem hiding this comment.
Can we see a control for a multi-line paragraph here?
jzempel
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates
react-notificationsexamples to Storybook.Checklist
?bedrock)