Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(avatars): update prop descriptions #926

Merged
merged 4 commits into from
Nov 9, 2020
Merged

chore(avatars): update prop descriptions #926

merged 4 commits into from
Nov 9, 2020

Conversation

KICKdesigns
Copy link
Contributor

@KICKdesigns KICKdesigns commented Nov 5, 2020 •
edited
Loading 

                                                                                                                  <!-- 🎗add a PR label 🎗-->

Description

Standardize prop descriptions and add @extends clauses.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@KICKdesigns KICKdesigns requested a review from a team as a code owner November 5, 2020 00:19
@KICKdesigns KICKdesigns changed the title chore(Avatar): update prop descriptions chore(avatar): update prop descriptions Nov 5, 2020
@KICKdesigns KICKdesigns changed the title chore(avatar): update prop descriptions chore(avatars): update prop descriptions Nov 5, 2020
@zendesk-garden zendesk-garden temporarily deployed to staging November 5, 2020 00:52 Inactive
@zendesk-garden zendesk-garden temporarily deployed to staging November 5, 2020 18:47 Inactive
@zendesk-garden zendesk-garden temporarily deployed to staging November 5, 2020 22:44 Inactive
@jzempel jzempel mentioned this pull request Nov 6, 2020
Closed
7 tasks
jzempel
jzempel reviewed Nov 6, 2020
View reviewed changes
Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check for passive->active voice.

@zendesk-garden zendesk-garden temporarily deployed to staging November 9, 2020 20:38 Inactive
@jzempel jzempel merged commit a29b164 into main Nov 9, 2020
@jzempel jzempel deleted the kickdesigns/avatar branch November 9, 2020 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzempel jzempel jzempel approved these changes

Assignees
No one assigned
Labels
PR: Docs 📝
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KICKdesigns @jzempel @zendesk-garden