Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): ensure typescript declarations are built with correct path #997

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

austingreendev
Copy link
Contributor

@austingreendev austingreendev commented Jan 26, 2021

Description

#996 found that our TS declarations are including their relative path (including package name) inside their type directories.

I was able to trace this back to #984 specifically this change.

By referencing the *.ts file (/src) rather than the compiled dist this is changing the declaration paths somehow. By updating this reference the TS declarations have the expected structure.

Checklist

  • πŸ‘Œ design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🀘 renders as expected with Bedrock CSS (?bedrock)
  • β™Ώ analyzed via axe and evaluated using VoiceOver
  • πŸ’‚β€β™‚οΈ includes new unit tests
  • πŸ“ tested in Chrome, Firefox, Safari, Edge, and IE11

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.727% when pulling 48835b6 on agreen/fix-ts-declarations into 22d91d7 on main.

@zendesk-garden zendesk-garden temporarily deployed to staging January 26, 2021 19:05 Inactive
@austingreendev austingreendev merged commit 7f931e7 into main Jan 26, 2021
@austingreendev austingreendev deleted the agreen/fix-ts-declarations branch January 26, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants