Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): revert ts-loader for webpack 4 support #315

Merged
merged 1 commit into from
May 18, 2021
Merged

fix(deps): revert ts-loader for webpack 4 support #315

merged 1 commit into from
May 18, 2021

Conversation

hzhu
Copy link
Contributor

@hzhu hzhu commented May 13, 2021

Description

The container stories aren't loading in the browser. This was due to a recent Renovate merge.

Detail

Further investigation shows that there are some errors during TS compilation:

Screen Shot 2021-05-13 at 3 27 22 PM

It looks like like ts-loader v9 does not support Webpack 4, so this PR reverts ts-loader back to 8.2.0 — which also allows the stories to render.

TypeStrong/ts-loader#595 (comment)

Checklist

  • 🌐 Storybook demo is up-to-date (yarn start)

@hzhu hzhu self-assigned this May 13, 2021
@hzhu hzhu requested a review from a team as a code owner May 13, 2021 22:37
@zendesk-garden zendesk-garden temporarily deployed to staging May 13, 2021 22:46 Inactive
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.462% when pulling 9444081 on hzhu/tsloader into a1f81af on main.

jzempel
jzempel approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't already, we need a TODO for getting this repo up to webpack 5.

@hzhu hzhu merged commit e36a3bf into main May 18, 2021
@hzhu hzhu deleted the hzhu/tsloader branch May 18, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzempel jzempel jzempel approved these changes

Assignees

@hzhu hzhu

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hzhu @coveralls @jzempel @zendesk-garden