This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
Always include 'aps' key #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
added a commit
that referenced
this pull request
May 8, 2018
As written in #49, tests broke. This patch: - Fixes a broken test - Modifies the `Message::getPayload()` routine to cast an empty `$aps` value to an empty object (to ensure it gets serialized correctly), while leaving other values intaqct. - Updates the test introduced in #18 to instead check for an empty object value for `aps`.
weierophinney
added a commit
that referenced
this pull request
May 8, 2018
weierophinney
added a commit
that referenced
this pull request
May 8, 2018
|
Thanks, @hipsterjazzbo; merged to develop for release with 1.3.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #18, a change was made to exclude the
apskey if it is empty. This causes totally empty notifications to fail (for example, when pushing to an Apple Wallet pass to trigger an update). The correct behavior to would be to include the emptyapskey encoded as a JSON object, like this:{ "aps": {} }This PR fixes this by always including the
"aps"key and casting$apsto an object, so that in the event it is empty it will be correctly encoded as an empty JSON object, rather that an empty JSON array as mentioned in #18.Reference: