This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
Add content length #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is required by google, i got a 411 HTTP error before adding this line
mwillbanks
suggested changes
Sep 28, 2016
| @@ -106,6 +106,7 @@ public function send(Message $message) | |||
| $client->setUri(self::SERVER_URI); | |||
| $headers = $client->getRequest()->getHeaders(); | |||
| $headers->addHeaderLine('Authorization', 'key=' . $this->getApiKey()); | |||
| $headers->addHeaderLine('Content-length', strlen($message->toJson())); | |||
There was a problem hiding this comment.
We can certainly add this, however, it needs to be mb_strlen and we will need to update the tests.
changed strlen to mb_strlen
|
Please rebase off of the current master branch. |
weierophinney
added a commit
that referenced
this pull request
May 8, 2018
Add content length Conflicts: library/Gcm/Client.php
weierophinney
added a commit
that referenced
this pull request
May 8, 2018
weierophinney
added a commit
that referenced
this pull request
May 8, 2018
|
Thanks, @sbo-develop; merged to develop for release with 2.1.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is required by google, i got a 411 HTTP error before adding this line