Skip to content
This repository has been archived by the owner on May 1, 2019. It is now read-only.

Fix: Do not json_decode API response to associative array #474

Merged
merged 5 commits into from
Mar 7, 2015

Conversation

localheinz
Copy link
Member

This PR

  • updates an integration test for the ContributorsController::contributorsAction() by actually providing the view with some contributor data
  • updates the tests expectations (and a view template relying on these expectations as well) for RepositoryRetriever::getContributors() to json_decode to objects
  • fixes the failing tests by actually json_decodeing to objects

See #447 (comment).

@localheinz localheinz self-assigned this Mar 6, 2015
@localheinz localheinz changed the title Fix: Do not json_decode API response to associative array [WIP] Fix: Do not json_decode API response to associative array Mar 6, 2015
@localheinz localheinz changed the title [WIP] Fix: Do not json_decode API response to associative array Fix: Do not json_decode API response to associative array Mar 6, 2015
@localheinz localheinz assigned Ocramius and unassigned localheinz Mar 6, 2015
@localheinz localheinz added the Bug label Mar 6, 2015
Ocramius added a commit that referenced this pull request Mar 7, 2015
Fix: Do not json_decode API response to associative array
@Ocramius Ocramius merged commit 39c8611 into zendframework:master Mar 7, 2015
@localheinz localheinz deleted the fix/json-decode branch March 8, 2015 08:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants