-
Notifications
You must be signed in to change notification settings - Fork 53
Redis::delete is deprecated #185
Comments
@gabrovex Would you like provide PR with this change? Thanks! |
@gabrovex @webimpress This happens since redis extension v5.0.0. As a workaround, you can downgrade to 4.3.0. My PR should fix that behaviour. |
https://travis-ci.org/zendframework/zend-cache/jobs/565853773#L1058 |
This is actually very good point. Now just wonder if by this change we are not introducing BC Break. We do not have any requirements on Redis version so I guess we should add. Probably also we would need update tests to run with previous version of Redis (4.x, maybe even 3.x?) |
@webimpress That's a very good point too. If the tests on all redis-server versions pass (no BC break), a new bugfix release could be made. |
@webimpress What I currently don't get, is, why the build fails on memcache for PHP 5.6 when I change a few calls in the Redis adapter. |
I think because other version of service/extension is now installed. I've checked latest passing build on master and for example I see there Redis 4.0.6, your build uses Redis 5.0.4 (but I guess there could be similar reason?) |
Any update on this? Its stopping us for using Zend\Cache at this point with the latest PHP version |
I'd suggest adding a |
Issue #185 : replacing deprecated delete() calls with del()
Provide a narrative description of what you are trying to accomplish.
Code to reproduce the issue
every call of
$redis->delete()
in here:https://github.com/zendframework/zend-cache/blob/master/src/Storage/Adapter/Redis.php
Expected results
not throwing deprecation errors
redis
delete
is deprecated. should be replaced withdel
https://redis.io/commands/del(using redis 3.2 on my server)
Actual results
The text was updated successfully, but these errors were encountered: