Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Failing test on indentation correction #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Failing test on indentation correction #83

wants to merge 1 commit into from

Conversation

Saeven
Copy link

@Saeven Saeven commented Jul 18, 2016

Requested here:
#82 (comment)

@Ocramius

Used reflection since the method is protected.

@Saeven Saeven mentioned this pull request Jul 18, 2016
@Ocramius Ocramius added the bug label Jul 18, 2016


$testMethod = '/** @return bool */ public function someMethod() { return false; }';
$clearedMethod = $method->invokeArgs( null, ['\t\t' . $testMethod]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test uses protected API calls to trigger the failure. I can't do much with this - can you write one that uses the public API?

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-code; a new issue has been opened at laminas/laminas-code#20.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-code. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-code to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-code.
  • In your clone of laminas/laminas-code, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants