This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Added more simple sniffs to the Zend Coding Standard #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
approved these changes
Dec 2, 2018
geerteltink
approved these changes
Dec 4, 2018
geerteltink
added a commit
that referenced
this pull request
Dec 4, 2018
Added more simple sniffs to the Zend Coding Standard
geerteltink
added a commit
that referenced
this pull request
Dec 4, 2018
|
Thanx @webimpress |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started testing the library with webimpress/coding-standard to release version 1.0.0 of my library.
I've added several simple sniffs here which I have implemented and override some with my version, as these are more reliable or fixes more cases (please see tests).
There is one problem with spaces around namespace operators.
I wanted to include that sniff, but looks like one sniff from Slevomat library wrongly recognised references and do a fix file with invalid use import:
use ;(it is only in first fix loop, then somehow it is removed, but it conflicts with other sniffs).