Auto include Module classes only for components not for modules

[michalbundyra]

As noticed by @jguittard in zfcampus/zf-apigility-doctrine#267 (comment) Module classes which implements some interfaces can't be autoloaded. Component installer needs to include only Module classes for component (because dependencies are checked only for component - when package have to be added on top).
This fix (hack...) include only Module classes when package type is component.
It is temporary solution, still it is not gonna work when component implements some interface. So far I don't know any package which is exposed as component and Module class implements some interfaces.

/cc @weierophinney @jguittard

[coveralls]

Coverage increased (+0.1%) to 91.529% when pulling 1925e4d on webimpress:hotfix/include-only-components into f6d41a4 on zendframework:master.

[jguittard]

@weierophinney any chance a quick 0.4.1 release?

[michalbundyra]

As long as it is not yet merged maybe we can go further and eliminate include at all. My idea is to use regular expression to extract method getModuleDependencies.

Do you think is it gonna be better solution?

/cc @weierophinney @jguittard

[weierophinney]

I'd argue either regex or tokenization; the latter is more reliable, but
would involve more code. Either way, stability and reliability should be
the goal.

Thanks, @webimpress!

On Oct 14, 2016 11:07 AM, "Michał Bundyra" notifications@github.com wrote:

As long as it is not yet merged maybe we can go further and eliminate
include at all. My idea is to use regular expression to extract method
getModuleDependencies.

Do you think is it gonna be better solution?

/cc @weierophinney https://github.com/weierophinney @jguittard
https://github.com/jguittard

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#23 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABlV9Rp88Eaykro2xkiyv1XaJyh4kkhks5qz6jFgaJpZM4KWskK
.

[weierophinney]

Closing, in favor of #24.