Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Allow injecting ConfigAggregator-based config files #31

Merged
merged 5 commits into from
Jan 9, 2017

Commits on Dec 20, 2016

  1. Allow injecting ConfigAggregator-based config files

    We recently added zend-config-aggregator, which will supercede
    zend-config-manager (developed by a third-party contributor as a
    stepping stone). This patch adds support for ConfigAggregator-based
    configuration files, while maintaining support for ConfigManager-based
    files.
    
    In order to make this work, we needed separate discovery and injector
    files. Since both identify the same filesystem location, this also means
    an injector chain - and those are intended to run _each_ injector.
    Because of that, the existing ExpressiveConfigInjector and the new
    ConfigAggregatorInjector now use a new trait, ConditionalDiscoveryTrait,
    which makes use of discovery classes in order to determine if
    injection/removal is necessary or possible before performing operations.
    weierophinney committed Dec 20, 2016
    Configuration menu
    Copy the full SHA
    17a2798 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dff4166 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2016

  1. Configuration menu
    Copy the full SHA
    7576839 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2017

  1. Test to ensure that indentation is kept

    Added tests to see if the ConfigAggregator injector correctly indents
    injected entries. To do this, I added new start/expected files that use
    an alternate coding style for declaring the `ConfigAggregator` instance.
    Currently, I observe the following:
    
    - Removal of a package works, and keeps expected indentation
    - Injection of a package does not keep expected indentation
    weierophinney committed Jan 5, 2017
    Configuration menu
    Copy the full SHA
    317ed01 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a2d6b4a View commit details
    Browse the repository at this point in the history