This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
SQLite $select->combine() support #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQLite does not allow parentheses in a union. You can find this in the documentation on SQLite located at: https://www.sqlite.org/lang_select.html as a secondary, you may look to a tutorial on unions in SQLite at: http://www.sqlitetutorial.net/sqlite-union/ This resolves issue #75 - SQLite error on UNION.
| * @covers Zend\Db\Sql\Platform\Sqlite\SelectDecorator::processOffset | ||
| * @dataProvider dataProvider | ||
| */ | ||
| public function testGetSqlString(Select $select, $ignore, $alsoIgnore, $expectedSql) |
There was a problem hiding this comment.
Can you give a more descriptive name, please? What is the behavior you're testing? E.g., "testGetSqlStringCorrectlyGeneratesUnionSyntaxFromCombine".
There was a problem hiding this comment.
I can, however, the existing tests on the platform all utilized this exact behavior, see the oracle and mysql tests for example.
* Change method names in tests to better relect the test * Update PHPDoc tags in methods
weierophinney
added a commit
that referenced
this pull request
Aug 9, 2016
SQLite $select->combine() support
weierophinney
added a commit
that referenced
this pull request
Aug 9, 2016
weierophinney
added a commit
that referenced
this pull request
Aug 9, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite does not allow parentheses in a union. You can find this in the
documentation on SQLite located at:
https://www.sqlite.org/lang_select.html as a secondary, you may look to
a tutorial on unions in SQLite at:
http://www.sqlitetutorial.net/sqlite-union/
This resolves issue #75 - SQLite error on UNION.