Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

never call DB Adapter service if no 'db' config provided #218

Merged
merged 2 commits into from Sep 8, 2016

Conversation

samsonasik
Copy link
Contributor

Use case:

  • composer require zendframework/zend-db
  • register as module
  • refresh
  • got undefined index 'db'

For new user that "just try" and see the 'undefined index "db"', it will stopping user to continue learning ;)

Use case:
- composer require zendframework/zend-db
- register as module
- refresh
- got undefined index 'db'

For new user that "just try" and see the 'undefined index "db"', it will stopping user to continue learning ;)
@arielkruger1989
Copy link

I agree with this. I had this problem and because I didn't have the environment variable APPLICATION_ENV set to development I could even see the error, only a 500 error with no exceptions showing.

Best,
Ariel Kruger

@weierophinney weierophinney added this to the 1.1.1 milestone Sep 8, 2016
@weierophinney weierophinney self-assigned this Sep 8, 2016
@weierophinney weierophinney merged commit f75787f into zendframework:master Sep 8, 2016
weierophinney added a commit that referenced this pull request Sep 8, 2016
never call DB Adapter service if no 'db' config provided
weierophinney added a commit that referenced this pull request Sep 8, 2016
weierophinney added a commit that referenced this pull request Sep 8, 2016
weierophinney added a commit that referenced this pull request Sep 8, 2016
@weierophinney
Copy link
Member

Thanks, @samsonasik!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants