Merge branch 'feature/37' into develop

Close #37
zendframework · Aug 29, 2018 · 753457e · 753457e
2 parents 45ac620 + dac51b2
commit 753457e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,6 +22,9 @@ All notable changes to this project will be documented in this file, in reverse
 - [#31](https://github.com/zendframework/zend-di/pull/31) adds the method
   `getNamespace()` to `Zend\Di\CodeGenerator\InjectorGenerator`.
 
+- [#37](https://github.com/zendframework/zend-di/pull/37) removes the use of `count()` 
+  in `Zend\Di\CodeGenerator\FactoryGenerator::buildParametersCode()` to improve performance   
+
 ### Deprecated
 
 - Nothing.

diff --git a/src/CodeGenerator/FactoryGenerator.php b/src/CodeGenerator/FactoryGenerator.php
@@ -134,7 +134,7 @@ private function buildParametersCode(string $type)
         $tab = str_repeat(' ', $intention);
         $code = '';
 
-        if (count($withOptions)) {
+        if ($withOptions) {
             // Build conditional initializer code:
             // If no $params were provided ignore it completely
             // otherwise check if there is a value for each dependency in $params.