Merge pull request #54 from tux-rampage/hotfix/preference-resolver-test

Add tests to ensure preference fallback behavior
zendframework · Jan 15, 2019 · 7a2e6d2 · 7a2e6d2
2 parents 615fc00 + dcf42bc
commit 7a2e6d2
Show file tree

Hide file tree

Showing 2 changed files with 112 additions and 0 deletions.
diff --git a/test/Resolver/DependencyResolverTest.php b/test/Resolver/DependencyResolverTest.php
@@ -640,4 +640,104 @@ public function testParametresResolverShouldNotCheckTheTypeForString()
         $this->assertInstanceOf(TypeInjection::class, $parameters['a']);
         $this->assertSame('my-service', $parameters['a']->__toString());
     }
+
+    /**
+     * Ensures the documented preference resolver behavior as documented
+     *
+     * @see https://docs.zendframework.com/zend-di/config/#type-preferences
+     */
+    public function testResolvePreferenceFallsBackToGlobalPreferenceWhenNotSuitableForClassRequirement()
+    {
+        $definition = new RuntimeDefinition();
+        $config = new Config();
+        $config->setTypePreference(TestAsset\A::class, TestAsset\B::class, TestAsset\RequiresA::class);
+        $config->setTypePreference(TestAsset\A::class, TestAsset\ExtendedA::class);
+        $resolver = new DependencyResolver($definition, $config);
+
+        $this->assertSame(
+            TestAsset\ExtendedA::class,
+            $resolver->resolvePreference(TestAsset\A::class, TestAsset\RequiresA::class)
+        );
+    }
+
+    /**
+     * Ensures the documented preference resolver behavior as documented
+     *
+     * @see https://docs.zendframework.com/zend-di/config/#type-preferences
+     */
+    public function testResolvePreferenceReturnsNullWhenNothingIsSuitableForClassRequirement()
+    {
+        $definition = new RuntimeDefinition();
+        $config = new Config();
+        $config->setTypePreference(TestAsset\A::class, TestAsset\ExtendedB::class, TestAsset\RequiresA::class);
+        $config->setTypePreference(TestAsset\A::class, TestAsset\B::class);
+        $resolver = new DependencyResolver($definition, $config);
+
+        $this->assertNull($resolver->resolvePreference(TestAsset\A::class, TestAsset\RequiresA::class));
+    }
+
+    /**
+     * Ensures the documented preference resolver behavior as documented
+     *
+     * @see https://docs.zendframework.com/zend-di/config/#type-preferences
+     */
+    public function testResolvePreferenceFallsBackToGlobalPreferenceWhenNotSuitableForInterfaceRequirement()
+    {
+        $definition = new RuntimeDefinition();
+        $config = new Config();
+        $config->setTypePreference(
+            TestAsset\Hierarchy\InterfaceB::class,
+            TestAsset\Hierarchy\InterfaceA::class,
+            TestAsset\A::class
+        );
+        $config->setTypePreference(TestAsset\Hierarchy\InterfaceB::class, TestAsset\Hierarchy\InterfaceC::class);
+        $resolver = new DependencyResolver($definition, $config);
+
+        $this->assertSame(
+            TestAsset\Hierarchy\InterfaceC::class,
+            $resolver->resolvePreference(TestAsset\Hierarchy\InterfaceB::class, TestAsset\A::class)
+        );
+    }
+
+    /**
+     * Ensures the documented preference resolver behavior as documented
+     *
+     * @see https://docs.zendframework.com/zend-di/config/#type-preferences
+     */
+    public function testResolvePreferenceReturnsNullWhenNothingIsSuitableForInterfaceRequirement()
+    {
+        $definition = new RuntimeDefinition();
+        $config = new Config();
+        $config->setTypePreference(
+            TestAsset\Hierarchy\InterfaceB::class,
+            TestAsset\B::class,
+            TestAsset\A::class
+        );
+        $config->setTypePreference(
+            TestAsset\Hierarchy\InterfaceB::class,
+            TestAsset\Hierarchy\InterfaceA::class
+        );
+        $resolver = new DependencyResolver($definition, $config);
+
+        $this->assertNull(
+            $resolver->resolvePreference(TestAsset\Hierarchy\InterfaceB::class, TestAsset\A::class)
+        );
+    }
+
+    public function testResolvePreferenceUsesDefinedClassForInterfaceRequirements()
+    {
+        $definition = new RuntimeDefinition();
+        $config = new Config();
+        $config->setTypePreference(
+            TestAsset\Hierarchy\InterfaceB::class,
+            TestAsset\Hierarchy\B::class
+        );
+
+        $resolver = new DependencyResolver($definition, $config);
+
+        $this->assertSame(
+            TestAsset\Hierarchy\B::class,
+            $resolver->resolvePreference(TestAsset\Hierarchy\InterfaceB::class, TestAsset\A::class)
+        );
+    }
 }
diff --git a/test/TestAsset/ExtendedA.php b/test/TestAsset/ExtendedA.php
@@ -0,0 +1,12 @@
+<?php
+/**
+ * @see       https://github.com/zendframework/zend-di for the canonical source repository
+ * @copyright Copyright (c) 2019 Zend Technologies USA Inc. (https://www.zend.com)
+ * @license   https://github.com/zendframework/zend-di/blob/master/LICENSE.md New BSD License
+ */
+
+namespace ZendTest\Di\TestAsset;
+
+class ExtendedA extends A
+{
+}