Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Commit

Permalink
Merge branch 'master' into hotfix/filter-validator-loading
Browse files Browse the repository at this point in the history
  • Loading branch information
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 14 deletions.
4 changes: 4 additions & 0 deletions src/Definition/ArrayDefinition.php
Expand Up @@ -9,6 +9,10 @@ class ArrayDefinition implements Definition

public function __construct(Array $dataArray)
{
foreach ($dataArray as $class => $value) {
// force lower names
$dataArray[$class] = array_change_key_case($dataArray[$class], CASE_LOWER);
}
$this->dataArray = $dataArray;
}

Expand Down
6 changes: 2 additions & 4 deletions src/Definition/CompilerDefinition.php
Expand Up @@ -9,8 +9,6 @@
Zend\Di\Definition\Annotation,
Zend\Code\Annotation\AnnotationManager,
Zend\Code\Reflection,
// Zend\Code\Scanner\FileScanner,
// Zend\Code\Scanner\MethodScanner,
Zend\Code\Annotation\AnnotationCollection;

class CompilerDefinition implements Definition
Expand Down Expand Up @@ -53,7 +51,7 @@ public function addDirectory($directory)

public function addDirectoryScanner(DirectoryScanner $directoryScanner)
{
$this->directoryScanner->addScanner($directoryScanner);
$this->directoryScanner->addDirectoryScanner($directoryScanner);
}

public function addCodeScannerFile(FileScanner $fileScanner)
Expand All @@ -68,7 +66,7 @@ public function addCodeScannerFile(FileScanner $fileScanner)
public function compile()
{
/* @var $classScanner \Zend\Code\Scanner\DerivedClassScanner */
foreach ($this->directoryScanner->getClasses() as $class) {
foreach ($this->directoryScanner->getClassNames() as $class) {
$this->processClass($class);
}
}
Expand Down
2 changes: 1 addition & 1 deletion test/Definition/ArrayDefinitionTest.php
Expand Up @@ -9,7 +9,7 @@ class ArrayDefinitionTest extends TestCase
{

/**
* @var Zend\Di\Definition\ArrayDefinition
* @var ArrayDefinition
*/
protected $definition = null;

Expand Down
2 changes: 1 addition & 1 deletion test/Definition/CompilerDefinitionTest.php
Expand Up @@ -13,7 +13,7 @@ public function testCompilerCompilesAgainstConstructorInjectionAssets()
$definition = new CompilerDefinition;
$definition->addDirectory(__DIR__ . '/../TestAsset/CompilerClasses');
$definition->compile();

$this->assertTrue($definition->hasClass('ZendTest\Di\TestAsset\CompilerClasses\A'));

$assertClasses = array(
Expand Down
16 changes: 8 additions & 8 deletions test/_files/definition-array.php
Expand Up @@ -5,7 +5,7 @@
array (
),
'instantiator' => '__construct',
'injectionMethods' =>
'methods' =>
array (
'__construct' =>
array (
Expand All @@ -16,22 +16,22 @@
),
'My\\EntityA' =>
array (
'superTypes' =>
'supertypes' =>
array (
),
'instantiator' => NULL,
'injectionMethods' =>
'methods' =>
array (
),
),
'My\\Mapper' =>
array (
'superTypes' =>
'supertypes' =>
array (
0 => 'ArrayObject',
),
'instantiator' => '__construct',
'injectionMethods' =>
'methods' =>
array (
'setDbAdapter' =>
array (
Expand All @@ -41,7 +41,7 @@
),
'My\\RepositoryA' =>
array (
'superTypes' =>
'superTypes' =>
array (
),
'instantiator' => '__construct',
Expand All @@ -55,12 +55,12 @@
),
'My\\RepositoryB' =>
array (
'superTypes' =>
'superTypes' =>
array (
0 => 'My\\RepositoryA',
),
'instantiator' => NULL,
'injectionMethods' =>
'Methods' =>
array (
),
),
Expand Down

0 comments on commit c24c880

Please sign in to comment.