This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Declare strict types #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before going here: are we on PHPStan level 7?
…On Fri, 16 Nov 2018, 21:24 Axel H. ***@***.*** wrote:
@tux-rampage <https://github.com/tux-rampage> requested your review on:
#45 <#45> Declare strict
types.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#45 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAJakHyCigVtotD0HPPwZ9z4KPpWfR5eks5uvx77gaJpZM4Ym6Pi>
.
|
|
Definitly a goal. Should I add it in this PR or another one? |
|
Another one, and we can apply this patch afterwards
…On Sat, 17 Nov 2018, 10:02 Axel H. ***@***.*** wrote:
Definitly a goal. Should I add it in this PR or another one?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakKgKhmRC5fK2WsoSHBLxrDkBhTL7ks5uv9CwgaJpZM4Ym6Pi>
.
|
17 tasks
|
Now this can be rebased 👌 Can you try and check which level of PHPStan works in the test suite? |
|
Sure will look at it later, maybe tomorrow. Thanks. |
tux-rampage
force-pushed
the
feature/strict-types
branch
from
cc9f5e6
to
d670566
Compare
tux-rampage
commented
Nov 22, 2018
| @@ -225,7 +227,7 @@ public function setTypePreference(string $type, string $preference, ?string $con | |||
| public function setAlias(string $name, string $class) : self | |||
| { | |||
| if (! class_exists($class) && ! interface_exists($class)) { | |||
| throw new Exception\ClassNotFoundException('Could not find class "' . $class . '"'); | |||
| throw new Exception\ClassNotFoundException($class); | |||
There was a problem hiding this comment.
This is a nitpick spotted while working on this. This call duplicates the message because ClassNotFoundException only expects the class name.
|
@Ocramius rebase is complete. I also changed the target branch from master to develop (idk why I didn't do that when opening this PR). |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All source files should declare strict types.
See Issue #41
Are you fixing a bug?
masterbranch, and submit against that branch.CHANGELOG.mdentry for the fix.Are you creating a new feature?
developbranch, and submit against that branch.CHANGELOG.mdentry for the new feature.Is this related to quality assurance?
This assures the common best practices of ZF components
Is this related to documentation?