Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Added PHP 7.3 support - updated Travis CI configuration #48

Merged
merged 2 commits into from
Dec 20, 2018
Merged

Added PHP 7.3 support - updated Travis CI configuration #48

merged 2 commits into from
Dec 20, 2018

Conversation

michalbundyra
Copy link
Member

No description provided.

Copy link
Contributor

@tux-rampage tux-rampage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing Build failures. There seems to be a Conding-Bug that was not yet spotted. I'll take a look at it later.

@weierophinney & @Ocramius does this need to be fixed first before this can be merged or merge and new PR with fix?

@tux-rampage tux-rampage self-assigned this Dec 18, 2018
@michalbundyra
Copy link
Member Author

@tux-rampage The problem is in zend-stdlib 2.7.7. I don't know what we are going to do with it. Technically PHP 7.3 is supported with latest dependencies. zend-stdlib v2 doesn't seem to be supported... Not sure how we can resolve failing build here - maybe remove "lowest" build from docker on PHP 7.3?

@weierophinney
Copy link
Member

Considering the component now requires PHP 7.1, there's no reason to support zend-stdlib 2.7 any longer; just drop that version from the constraint, and you should be good to go.

@michalbundyra
Copy link
Member Author

@tux-rampage PR is now updated

@tux-rampage tux-rampage merged commit e649f73 into zendframework:develop Dec 20, 2018
tux-rampage added a commit that referenced this pull request Dec 20, 2018
Added PHP 7.3 support - updated Travis CI configuration
tux-rampage added a commit that referenced this pull request Dec 20, 2018
@michalbundyra michalbundyra deleted the feature/php-7.3-support branch December 20, 2018 20:42
tux-rampage added a commit that referenced this pull request Jan 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants