This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Updated ValueInjection to check array values as these can be exportable #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted logic from isExportable function to private function and use recursion for arrays.
tux-rampage
suggested changes
Jan 9, 2019
There was a problem hiding this comment.
Looks good. Just a minor nitpick. I'd consider it as bug as well, if there are no objections I'd target this to 3.1.1 - @Ocramius ?
tux-rampage
approved these changes
Jan 10, 2019
tux-rampage
added a commit
that referenced
this pull request
Jan 10, 2019
…ble-arrays Updated ValueInjection to check array values as these can be exportable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted logic from isExportable function to private function and use recursion for arrays.
Because array values (especially empty array values) were not recognised as exportable factories for classes with empty array as default value for param were not created.
masterbranch, and submit against that branch.CHANGELOG.mdentry for the fix.