Fixes typo IM Used response reason phrase typo #230
Conversation
uses uppercase for "used"
samsonasik
changed the title
|
Ref: #208 |
|
@samsonasik is there any way to test these status codes from an RFC list or such? |
|
@Ocramius not sure..., probably use ReflectionProperty ? |
|
@samsonasik yeah, that part is indeed trivial, but we need some sort of authoritative list to compare against, or else we'll keep having these failures, especially if the spec is extended |
|
Yes, and is there no parseable version somewhere? Going paragraph per
paragraph seems silly
…On 7 Feb 2017 7:39 p.m., "Sina Sharifzade" ***@***.***> wrote:
@Ocramius <https://github.com/Ocramius> https://tools.ietf.org/html/
rfc3229#section-10.4.1
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#230 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakJLXai0YBiNiCtMbL9uZ6YzYXCC-ks5raLpqgaJpZM4L5WXG>
.
|
|
@Ocramius I have linked the section with the URL, section 10.4.1 |
|
Yes, and we'd need that for every paragraph 😅
…On 7 Feb 2017 19:56, "Sina Sharifzade" ***@***.***> wrote:
@Ocramius <https://github.com/Ocramius> I have linked the section with
the URL, section 10.4.1
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#230 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakJ7LjreUrSdnHEELDKd8XzUgQUoEks5raL5CgaJpZM4L5WXG>
.
|
|
Must be an authoritative source of truth, not another implementation.
Anyway, I'm nitpicking: if this isn't feasible or practical, then this is
ready as-is
…On 7 Feb 2017 20:22, "Sina Sharifzade" ***@***.***> wrote:
@Ocramius <https://github.com/Ocramius>
https://en.wikipedia.org/wiki/List_of_HTTP_status_codes
https://github.com/elegantweb/framework/blob/master/src/
Elegant/Http/Message/Response.php#L35-L94
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#230 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakNhBUCQv9wpHBiTTWpzGKd0vOphXks5raMRlgaJpZM4L5WXG>
.
|
|
@Ocramius Have you ever seen the WikiPedia page? implementation is just for making your job easier ;) |
|
Eh, Wikipedia is not the IETF, although it's probably stable enough
…On 7 Feb 2017 20:28, "Sina Sharifzade" ***@***.***> wrote:
@Ocramius <https://github.com/Ocramius> Have you ever seen the WikiPedia
page? implementation is just for making your job easier ;)
anyway you need also change status code 505 and 207.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#230 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakD5ciaSFjOK2rnbkBw_bn6Uqolscks5raMXBgaJpZM4L5WXG>
.
|
|
@Ocramius Yes, but you can find RFC numbers for each standard status code. |
|
@Ocramius Accurate, updated (e.g. 408, 413, 414, 416, 505) and ease to parse (xml). http://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml However, is not perfect, some codes are missing (maybe unofficial or Easter egg - 418) |
Fixes typo IM Used response reason phrase typo
|
Thanks, @samsonasik |
uses uppercase for "used", changed to "Used"