This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Prefix authority with double slash if present. #235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgrim
reviewed
Mar 11, 2017
There was a problem hiding this comment.
Although having read through the interface and looking at the Guzzle implementation I agree that this patch fixes an issue. However, it does introduce a BC break (as some things may rely on this already not having // prefixed)
| public function testAuthorityIsPrefixedByDoubleSlashIfPresent() | ||
| { | ||
| $uri = (new Uri())->withHost('example.com'); | ||
| $this->assertEquals('//example.com', (string) $uri); |
There was a problem hiding this comment.
This test is exactly the same as testUriDoesNotAppendColonToHostIfPortIsEmpty except the URL used... not sure we need both except for being explicit.
|
Every bug fixed is a sort of BC break as you cannot know if there are things that relay on the old behavior, but for me it should be fixed in order to be PSR7 compliant. |
|
@ajgarlag why you have closed this PR? |
|
@sharifzadesina It was an error, |
weierophinney
approved these changes
Apr 6, 2017
weierophinney
added a commit
that referenced
this pull request
Apr 6, 2017
Prefix authority with double slash if present.
weierophinney
added a commit
that referenced
this pull request
Apr 6, 2017
weierophinney
added a commit
that referenced
this pull request
Apr 6, 2017
|
Merged to develop for release with 1.4.0. Thanks, @ajgarlag |
jesseschalken
added a commit
to ivt/zend-diactoros
that referenced
this pull request
May 15, 2017
zend-diactoros 1.4.0 Added ----- - [zendframework#219](zendframework#219) adds two new classes, `Zend\Diactoros\Request\ArraySerializer` and `Zend\Diactoros\Response\ArraySerializer`. Each exposes the static methods `toArray()` and `fromArray()`, allowing de/serialization of messages from and to arrays. - [zendframework#236](zendframework#236) adds two new constants to the `Response` class: `MIN_STATUS_CODE_VALUE` and `MAX_STATUS_CODE_VALUE`. Changes ------- - [zendframework#240](zendframework#240) changes the behavior of `ServerRequestFactory::fromGlobals()` when no `$cookies` argument is present. Previously, it would use `$_COOKIES`; now, if a `Cookie` header is present, it will parse and use that to populate the instance instead. This change allows utilizing cookies that contain period characters (`.`) in their names (PHP's built-in cookie handling renames these to replace `.` with `_`, which can lead to synchronization issues with clients). - [zendframework#235](zendframework#235) changes the behavior of `Uri::__toString()` to better follow proscribed behavior in PSR-7. In particular, prior to this release, if a scheme was missing but an authority was present, the class was incorrectly returning a value that did not include a `//` prefix. As of this release, it now does this correctly. Deprecated ---------- - Nothing. Removed ------- - Nothing. Fixed ----- - Nothing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PSR-7 docblock of the
UriInterface::__toStringmethod, states that:This PR tests and fixes that behavior.