Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

remove superfluous $scheme empty test #291

Merged
merged 1 commit into from
Feb 26, 2018
Merged

remove superfluous $scheme empty test #291

merged 1 commit into from
Feb 26, 2018

Conversation

pine3ree
Copy link
Contributor

$scheme is never empty as it was initialized to 'http'

michalbundyra
michalbundyra approved these changes Feb 12, 2018
View reviewed changes
Copy link
Member

@michalbundyra michalbundyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@weierophinney weierophinney merged commit 69088d0 into zendframework:master Feb 26, 2018
weierophinney added a commit that referenced this pull request Feb 26, 2018
@weierophinney
Merge pull request #291 from pine3ree/srf-remove-empty-test
43201f6 
remove superfluous $scheme empty test
weierophinney added a commit that referenced this pull request Feb 26, 2018
@weierophinney
Merge branch 'hotfix/291'
393be9c 
Close #291
weierophinney added a commit that referenced this pull request Feb 26, 2018
@weierophinney
Merge branch 'hotfix/291' into develop
accb8bc 
Forward-port #291
@weierophinney
Copy link
Member

Thanks, @pine3ree.

@pine3ree pine3ree deleted the srf-remove-empty-test branch March 3, 2018 20:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michalbundyra michalbundyra michalbundyra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pine3ree @weierophinney @michalbundyra