Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

make string comparison more strict #301

Merged
merged 1 commit into from
May 29, 2018
Merged

make string comparison more strict #301

merged 1 commit into from
May 29, 2018

Conversation

nyamsprod
Copy link
Contributor

This PR resolves the following bug in the Uri class:

<?php

use Zend\Diactoros\Uri;
$uri = new Uri('https://0:0@0:1/0?0#0'); // display https:/0'
// expected 'https://0:0@0:1/0?0#0'

All string comparison are made more strict now.

Maybe other PRs may look and fix this issue in other classes as well.

@weierophinney weierophinney merged commit 765fcd0 into zendframework:master May 29, 2018
weierophinney added a commit that referenced this pull request May 29, 2018
@weierophinney
Merge pull request #301 from bakame-php/bugfix/Uri-toString-method
943fd88 
make string comparison more strict
weierophinney added a commit that referenced this pull request May 29, 2018
@weierophinney
Adds CHANGELOG entry for #301
1eac731
weierophinney added a commit that referenced this pull request May 29, 2018
@weierophinney
Merge branch 'hotfix/301'
741e7a5 
Close #301
weierophinney added a commit that referenced this pull request May 29, 2018
@weierophinney
Merge branch 'hotfix/301' into develop
4dc9f9d 
Forward port #301

Conflicts:
	CHANGELOG.md
weierophinney added a commit that referenced this pull request May 29, 2018
@weierophinney
Merge branch 'hotfix/301' into release-2.0
4f08119 
Forward port #301

Conflicts:
	CHANGELOG.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@malukenho malukenho malukenho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nyamsprod @malukenho @weierophinney